On Monday 23 March 2009, Sudhakar Rajashekhara wrote:
> Adds support for MMC/SD on TI's DA830 architecture.
Also known as OMAP-L137? Regardless, if that chip
has the same issue, please update comments accordingly.
Likewise on the EDMA patch.
This looks like *partial* support for at least the
OMAP-L137. It omits the HSMMC/eMMC support for 8-bit
parallel I/O. So $SUBJECT might usefully reference
EDMA too ... :)
A procedural nit: now that the DaVinci MMC driver
has been sent for mainline inclusion -- although not
yet merged -- I'd send the next iteration of this
patch to LKML, referencing the patches on which it
relies: (a) that MMC driver, (b) platform support
for EDMA.
> On TI's DA830, the DMATRIG bit should be set for CPU transfers.
As Sergei noted, "PIO transfers".
> +enum {
> + MMC_CTLR_VERSION_1, /* DM644x and DM355 */
> + MMC_CTLR_VERSION_2, /* DA830 */
> +};
> +
Make that explicit: MMC_CTR_VERSION_1 = 0 will avoid
some confusion.
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
