Sergei, Thanks for your comments.
> Hello. > > Sudhakar Rajashekhara wrote: > > > Adds support for MMC/SD on TI's DA830 architecture. > > > On TI's DA830, the DMATRIG bit should be set for CPU transfers. > > Could you call them PIO transfers for clarity? I agree with this. Will change it to PIO. .... .... .... > > @@ -317,6 +320,10 @@ static void mmc_davinci_start_command(struct > mmc_davinci_host *host, > > if (host->do_dma) > > cmd_reg |= MMCCMD_DMATRIG; > > > > + if ((host->version == MMC_CTLR_VERSION_2) && (host->data != NULL) > && > > + (host->data_dir == DAVINCI_MMC_DATADIR_READ)) > > Unneeded parens around == and !=. I'll remove them. > > > @@ -1114,6 +1127,9 @@ static int __init davinci_mmcsd_probe(struct > platform_device *pdev) > > if (!pdata || pdata->wires == 4 || pdata->wires == 0) > > mmc->caps |= MMC_CAP_4_BIT_DATA; > > > > + if (pdata->version) > > Unneeded check... I'll remove this check. Regards, Sudhakar > > > + host->version = pdata->version; > > + > > WBR, Sergei_______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
