On Fri, Apr 03, 2009 at 06:43:42PM +0400, Sergei Shtylyov wrote: > Mark A. Greer wrote: > >>> "Mark A. Greer" <[email protected]> writes: > >>> [...] > >>>> diff --git a/arch/arm/mach-davinci/clock.h b/arch/arm/mach-davinci/clock.h >>>> index 91c24e6..9d09105 100644 >>>> --- a/arch/arm/mach-davinci/clock.h >>>> +++ b/arch/arm/mach-davinci/clock.h >>>> @@ -66,6 +66,7 @@ struct clk { >>>> u8 usecount; >>>> u8 flags; >>>> u8 lpsc; >>>> + u8 ctlr; >>> >>> How about psc_ctlr. Just a little more clear since it's in a 'struct >>> clk' it might be assumed it's a clock controller. > >> Good idea. > > As if 'psc' didn't include the controller already... That 'lpsc' was > pretty badly chosen name, it shoiuld've been 'module' instead, and we > then could use 'lpsc' ISO 'ctlr'. How about fixing this now -- at last?
I'm not sure I followed you but, 'lpsc' is the correct name for what we use it for. 'ctlr' isn't, though. 'module' is what the documentation calls what I used 'ctlr' for in the code so I'll change it. Mark -- _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
