Hello, I wrote:
diff --git a/arch/arm/mach-davinci/clock.h b/arch/arm/mach-davinci/clock.hindex 91c24e6..9d09105 100644 --- a/arch/arm/mach-davinci/clock.h +++ b/arch/arm/mach-davinci/clock.h @@ -66,6 +66,7 @@ struct clk { u8 usecount; u8 flags; u8 lpsc; + u8 ctlr;
How about psc_ctlr. Just a little more clear since it's in a 'struct clk' it might be assumed it's a clock controller.
Good idea.
No, not at all good -- it'll be just tautological.
As if 'psc' didn't include the controller already... That 'lpsc' was pretty badly chosen name, it shoiuld've been 'module' instead, and we then could use 'lpsc' ISO 'ctlr'. How about fixing this now -- at last?
I'm not sure I followed you but, 'lpsc' is the correct name for what we use it for.
No, it's not correct: LPSC means *local power and sleep controller*, what the field is used for is the module number within this controller of the peripheral's clock/power for which it controls.
After looking into the documentation once more: oops, I stand corrected. LPSC and module mean the same thing, but not the same as just PSC. So, indeed 'lpsc' was a correct name but it better be called 'module' to avoid the tauthological mess that we're going to have now if we want to call 'ctlr' 'psc'.
'ctlr' isn't, though.
It is.
'module' is what the documentation calls what I used 'ctlr' for in the code so I'll change it.
It's all vice versa. :-)
'ctlr' is equivalent to PSC # or (most probably it's the same) GPSC #. How about calling the field 'gpsc'?
Mark --
WBR, Sergei _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
