On Mon, Jun 22, 2009 at 11:19:01, David Brownell wrote: > On Sunday 21 June 2009, Nori, Sekhar wrote: > > On Sun, Jun 21, 2009 at 20:16:19, Paulraj, Sandeep wrote: > > > From: Sandeep Paulraj <[email protected]> > > > > > > Patch adds support for the RTC Driver in DM365. > > > > The MAINTAINERS file mentions the RTC Subsystem ML as > > [email protected]. This probably will have to get posted there as > > well. > > After another round or two, sure. I'd make sure > it passes "rtctest" first. > > > > > +#define DM365_RTCIF_PID_REG 0x00 > > That comment about these registers being IP-specfic would > seem to apply to all the registers and the driver name, yes? > > So maybe the name should be "davinci_rtc" and the
I wanted to suggest that but stopped short because there can be many different RTCs used on DaVinci platforms. The da8xx/omap-l1xx has another RTC which is different from this one. But, I agree, we can call this davinci_rtc and the next RTC driver can figure its own name. > driver-internal register and function names can be less > painfully long ... just RTC_PID_REG or somesuch. > [...] > > > > > +static irqreturn_t dm365_rtc_isr(int irq, void *class_dev) > > > > Can we drop the dm365_ prefix for the static functions? These functions > > should be applicable on the next platform that uses this IP and being > > static, its easy to drop the prefix. The comment also applies to some of the > > static variables declared earlier in the file. > > Keep *some* prefix though, like davinci_rtc_isr() or somesuch. > > The "rtc_" prefix is very generic, and will sometimes show up > in stack backtraces. Plus, it's not clear there won't be more > than one RTC on a system. (It's likely that a discrete RTC > that's optimized for low power could use less power than the > PRTSS module ... that tradeoff could matter.) I get the backtrace part, but how does calling the isr routine just rtc_isr() prevent multiple RTCs on the system? The function is static so there should be no namespace issues.. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
