Hi Kevin, The change does initialize the codec, but still the clock doesn't seem to be correct. I am still getting the underrun messages and also clock times out faster than it is suppose to be. For example I have 10 secs loopback using aplay and arecord, but the app runs only for 2 secs.
Thanks, Arun -----Original Message----- From: Kevin Hilman [mailto:[email protected]] Sent: Monday, July 13, 2009 11:55 AM To: Narnakaje, Snehaprabha Cc: Mani, Arun; Troy Kisky; [email protected]; Mark Brown; [email protected]; Medisetty, Naresh Subject: Re: [PATCH 07/26] davinci: dm646x: Adds McASP clock "Narnakaje, Snehaprabha" <[email protected]> writes: > Did you happen to test Audio on DM6446 with the latest on linux-davinci tree? > > For the same clock name issue Arun is running into on DM355, the codecs are > not getting detected on DM6446. > > Advanced Linux Sound Architecture Driver Version 1.0.20. > No device for DAI tlv320aic3x > No device for DAI davinci-i2s > ALSA device list: > No soundcards found. > > I am thinking we are seeing these issues due to the way dm355 (or dm6446) > clocks are defined on linux-davinci tree and the mach-davinci on kernel.org. > >>From arch/arm/mach-davinci/dm355.c of kernel.org > CLK("soc-audio.0", NULL, &asp0_clk), > CLK("soc-audio.1", NULL, &asp1_clk), > > And from arch/arm/mach-davinci/dm355.c of linux-davinci tree > CLK(NULL, "asp0", &asp0_clk), > CLK(NULL, "asp1", &asp1_clk), > > Kevin, any comments? Yes, ASoC drivers are headed upstream and there's currently a mismatch between the patches that are going upstream via linux-davinci and those going upstream via the ASoC tree. linux-davinci is missing some of the changes that are queued up in Mark Brown's for-2.6.32 branch, namely the change that addes the name argument to clk_get(). On linux-davinci, if you switch back to this form of CLK definition: CLK("soc-audio.0", NULL, &asp0_clk), CLK("soc-audio.1", NULL, &asp1_clk), does it work for you again? Kevin >> -----Original Message----- >> From: [email protected] >> [mailto:[email protected]] On Behalf >> Of Mani, Arun >> Sent: Friday, July 10, 2009 5:26 PM >> To: Troy Kisky >> Cc: [email protected]; Mark Brown; linux-arm- >> [email protected]; Medisetty, Naresh >> Subject: RE: [PATCH 07/26] davinci: dm646x: Adds McASP clock >> >> The clock is indeed initialized in board_dm355.c. The problem is the clock >> name is not given to the clk_get function. I hard coded the clock name to >> asp1(since it is dm355) and found out that this helps register the i2s and >> aic33x. but when I ran aplay and arecord, the clock is not correct and >> moreover there are lot or underruns detected. BTW it is also detected in >> the DM6446 case. >> >> >> -----Original Message----- >> From: Troy Kisky [mailto:[email protected]] >> Sent: Friday, July 10, 2009 3:48 PM >> To: Mani, Arun >> Cc: Mark Brown; [email protected]; linux-arm- >> [email protected]; Medisetty, Naresh >> Subject: Re: [PATCH 07/26] davinci: dm646x: Adds McASP clock >> >> Mani, Arun wrote: >> > Hi, >> > I am trying the latest 2.6.31 rc2 branch. I am trying to make the Audio >> work. >> > I found that the I2S clock is set to NULL. Because of this I am getting >> a NODEV error. >> > If I commented the check, I was able to map the I2S to the AIC33X. but I >> am not getting any sound. >> You need a clock, so don't comment out the check, rather give it one. ie. >> >> +static struct snd_platform_data snd_data = { >> + .clk_name = "asp0", >> +}; >> + >> static struct i2c_board_info __initdata i2c_info[] = { >> { >> I2C_BOARD_INFO("ths8200", 0x21), >> @@ -230,6 +234,7 @@ static __init void board_init(void) >> platform_add_devices(davinci_devices, >> ARRAY_SIZE(davinci_devices)); >> davinci_serial_init(&uart_config); >> + dm644x_init_asp(&snd_data); >> >> >> > I tried the aplay and arecord and got the read/write errors. >> > >> > Any thoughts? >> > >> > Thanks, >> > Arun. >> > >> >> >> _______________________________________________ >> Davinci-linux-open-source mailing list >> [email protected] >> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source > _______________________________________________ > Davinci-linux-open-source mailing list > [email protected] > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
