Troy Kisky <[email protected]> writes: > Kevin Hilman wrote: >> Well, it's not actually this patch that started the problem, it was >> the platform_data updates where clock names were added as part of the >> new platform_data struct shared between platform code and ASoC. >> >> My original proposal was to pass a clock pointer, not a clock name, >> but that was not done, so... >> >> I've pushed an update my 'temp/asoc' branch with the patch below which >> converts to pasing clock pointers instead of clock names. >> >> I'll rework this into two parts. One for DaVinci git and one for >> Mark's for-2.6.32 branch and submit. >> >> Kevin >> > > Can you explain the philosophy of why this is better than the > previous? They look about the same to me. Both call clk_get with a > name string, just in a different place.
Correct. But in the updatd version, the code that uses the name is platform specific code that has to know which physical clock to hook up. The point is that we should not be passing around platform-dependent physical clock name strings to platform-indepenent code. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
