Hello. Nori, Sekhar wrote:
Hello.
Sekhar Nori wrote:
On the DA830, AEMIF and MMC/SD pins are shared. On the EVM, when the mux_mode signal is low MMC/SD works and when mux_mode signal is high, NAND works.
When MMC/SD driver is configured in the kernel, do not let NAND get registered and drive mux_mode high. Instead, print a warning for user to understand why the platform device for NAND did not get registered.
Signed-off-by: Sekhar Nori <[email protected]>
[...]
diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c index 6de058f..4fb0447 100644 --- a/arch/arm/mach-davinci/board-da830-evm.c +++ b/arch/arm/mach-davinci/board-da830-evm.c @@ -253,6 +253,12 @@ static const short da830_evm_emif25_pins[] = { -1 }; +#if defined(CONFIG_MMC_DAVINCI) || defined(CONFIG_MMC_DAVINCI_MODULE) +#define HAS_MMC 1 +#else +#define HAS_MMC 0 +#endif
This is not needed. Why not just use #ifdef's directly?
May be it's a personal preference, but I like this better than seeing #ifdefs embedded in function body. Besides, that would be a direct violation of Documentation/SubmittingPatches section 2.2
What you're doing is also against the community's practices as Mark has already pointed IIRC.
Thanks, Sekhar
WBR, Sergei _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
