Sekhar Nori <[email protected]> writes:
> This patch supports runtime detection of DA830 UI card and
> eliminates the need for DA830_UI config option. Successful
> probe of GPIO expander present on the UI card is used to
> detect its presence. For this reason, GPIO_PCF857X is auto-
> selected when DA830 EVM is configured. In case the UI card
> is absent, the probe fails in reasonable time.
>
> As a side effect this patch also gets rid of the voilation
> of Documentation/SubmittingPatches section 2.2 in function
> da830_evm_ui_expander_setup()
>
> Signed-off-by: Sekhar Nori <[email protected]>
Looks great, thanks.
One comment/question below.
[...]
> +static int da830_evm_ui_expander_setup(struct i2c_client *client, int gpio,
> + unsigned ngpio, void *context)
> +{
> + gpio_request(gpio + 6, "MUX_MODE");
This name isn't very descripitve when seen in debugfs. Would "UI mux mode"
be more appropriate? If not, please suggest something else and I'll
update before committing.
Thanks,
Kevin
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
