Victor Rodriguez <[email protected]> writes:

> On Thu, Sep 2, 2010 at 8:54 AM, Victor Rodriguez <[email protected]> wrote:
>> On Thu, Sep 2, 2010 at 5:40 AM, Sergei Shtylyov <[email protected]> wrote:
>>> On 02.09.2010 4:30, Victor Rodriguez wrote:
>>>
>>>>>> Basic support for Hawkboard OMAPL138 just UART cominication is included
>>>
>>>>>> Signed-off-by: Victor Rodriguez<[email protected]>
>>>
>>>>>> Notes:  This patch deletes empty lines and typo mistakes from previous
>>>>>> version
>>>
>>>>>   These notes belong to the space under the --- tear line, not to the
>>>>> patch
>>>>> description.
>>>
>>>> Ok sorry my mistake, fIxed for next version
>>>
>>>>>>        This patch is checked with
>>>>>> 0a50e05b20f3c6af67656303bdb3661a2541ce03
>>>>>> from
>>>>>>        Kernel development tree for TI DaVinci family of processors
>>>
>>>>>>        This patch works with basic da8xx_omapl_defconfig, it just have
>>>>>> basic support
>>>>>>        for UART console
>>>
>>>>>>        This patch just works with UART 2 for argo file system
>>>
>>>>>> Signed-off-by: Victor Rodriguez<[email protected]>
>>>
>>>>> [...]
>>>
>>>>>> diff --git a/arch/arm/mach-davinci/Kconfig
>>>>>> b/arch/arm/mach-davinci/Kconfig
>>>>>> index 2bf03e9..fd8a11c 100644
>>>>>> --- a/arch/arm/mach-davinci/Kconfig
>>>>>> +++ b/arch/arm/mach-davinci/Kconfig
>>>>>> @@ -185,6 +185,15 @@ config MACH_TNETV107X
>>>>>>        help
>>>>>>          Say Y here to select the TI TNETV107X Evaluation Module.
>>>>>>  +config MACH_OMAPL138_HAWKBOARD
>>>>>> +       bool "TI DA850/OMAP-L138/AM18xx Hawkboard(.org) Platform"
>>>>>> +       default ARCH_DAVINCI_DA850
>>>
>>>>>   As I've already said, only EVM boards are enabled by default.
>>>
>>>> Question i have deleted the
>>>
>>>> default ARCH_DAVINCI_DA850
>>>
>>>> but I have a problem because my board-da850-hawk.c does not compile
>>>> and because of that when i boot the uImage is impossible to uncompress
>>>> my kernel image.
>>>
>>>> So do you suggest any other way to fix that with out altering the
>>>> da8xx_omapl_defconfig?
>>>
>>>   Why do you not want to alter it? I think you should.
>>
>>
>> Because the discussion that exist in defconfig files in the
>> [email protected] mailing list, Linus complain about the
>> lack of order in defconfig files.

That's a slightly separate issue.  Linus has been irritated with the
huge number of defconfigs.  Making readable changes to them is just fine.

>> But if you sugest that is ok i would try to modify .
>>
>> So i leave the Kconfig just like this ?
>>
>> +config MACH_OMAPL138_HAWKBOARD
>> +       bool "TI DA850/OMAP-L138/AM18xx Hawkboard(.org) Platform"
>> +       depends on ARCH_DAVINCI_DA850
>> +       help
>> +         Say Y here to select the TI DA850/OMAP-L138/AM18xx Hawkboard.
>> +         Information of this board may be found at
>> +         http://www.hawkboard.org/
>
> One more question
>
> I have checked the Michael Williamson patch and he has
>
> +config MACH_MITYOMAPL138
> +       bool "Critical Link MityDSP-L138/MityARM-1808 SoM"
> +       default ARCH_DAVINCI_DA850 >> just like my patch
> +       depends on ARCH_DAVINCI_DA850
> +       help
> +         Say Y here to select the Critical Link MityDSP-L138/MityARM-1808
> +         System on Module.  Information on this SoM may be found at
> +         http://www.mitydsp.com
> +
>
> Why is this ok ?

His hasn't been merged yet either.

> And he only alter the da8xx-omapl-defconfig by this way
>
>
> diff --git a/arch/arm/configs/da8xx_omapl_defconfig
> b/arch/arm/configs/da8xx_omapl_defconfig
> index ba66705..3952a4e 100644
> --- a/arch/arm/configs/da8xx_omapl_defconfig
> +++ b/arch/arm/configs/da8xx_omapl_defconfig
> @@ -79,6 +79,7 @@ CONFIG_I2C_DAVINCI=y
>  # CONFIG_HWMON is not set
>  CONFIG_WATCHDOG=y
>  CONFIG_REGULATOR=y
> +CONFIG_REGULATOR_DUMMY=y
>  CONFIG_REGULATOR_TPS6507X=y
>  CONFIG_FB=y
>  CONFIG_FB_DA8XX=y

This is an unrelated change.

> Any clue what I am doing this wrong

So, what Sergei mentioned is that by default, in the Kconfigs, the
(relatively arbitrary) policy we've had is that only the TI official
EVMs have been enabled by default *in the Kconfig*.

IOW, Sergei is suggesting that you don't enable your board by default in
the Kconfig, but you should enable it by default in
da8xx_omapl_defconfig.

Kevin
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to