Hello.
On 01-12-2010 12:05, Subhasish Ghosh wrote:
Signed-off-by: Subhasish Ghosh<[email protected]>
---
arch/arm/mach-davinci/board-da850-evm.c | 36 +++++++++++++++++++++++++++++++
1 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-davinci/board-da850-evm.c
b/arch/arm/mach-davinci/board-da850-evm.c
index f89b0b7..3563a46 100644
--- a/arch/arm/mach-davinci/board-da850-evm.c
+++ b/arch/arm/mach-davinci/board-da850-evm.c
@@ -43,6 +43,7 @@
#define DA850_MMCSD_CD_PIN GPIO_TO_PIN(4, 0)
#define DA850_MMCSD_WP_PIN GPIO_TO_PIN(4, 1)
+#define DA850_PRU_CAN_TRX_PIN GPIO_TO_PIN(2, 0)
Please align with the others.
@@ -188,6 +189,41 @@ static struct platform_device *da850_evm_devices[]
__initdata = {
&da850_evm_norflash_device,
};
+const short da850_pru_can_pins[] = {
Prefix should be da850_evm_.
+ DA850_PRU0_R31_0, DA850_PRU1_R30_15, DA850_PRU1_R31_18,
I thought you wanted to use GPIO2[0] too?
+ -1
+};
+
+static int __init da850_evm_setup_pru_can(void)
+{
+ int ret;
+
+ if (!machine_is_davinci_da850_evm())
+ return 0;
+
+ ret = davinci_cfg_reg_list(da850_pru_can_pins);
+ if (ret)
+ pr_warning("da850_evm_init:
You're not in that function. Use the '__func__' variable to print the
current function's name.
da850_pru_can_pins mux setup"
You forgot to add space after "setup", else it'll look loke "setupfailed".
+ "failed:%d\n", ret);
Probably need space before "%d"...
+ ret = davinci_cfg_reg(DA850_GPIO2_0);
+ if (ret)
+ pr_warning("da850_evm_init:GPIO(2,0) mux setup "
Again, you're not in that function. Probably need space before "GPIO"...
+ ret = da8xx_register_pru_can();
+ if (ret)
+ pr_warning("da850_evm_init: pru can registration failed:"
Not in that function. Probably need space after "failed:"...
+ "%d\n", ret);
+ return ret;
+}
+device_initcall(da850_evm_setup_pru_can);
+
#define DA8XX_AEMIF_CE2CFG_OFFSET 0x10
#define DA8XX_AEMIF_ASIZE_16BIT 0x1
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
