Hello.

S.Ghosh wrote:

   Please don't use HTML, as it spoils message quoting when I reply.

      Not sure why you mention DA850 EVM in the subject -- this patch
    doesn't touch it.

[SG] -- Should I mention it as "davinci: ".

   Why not just DA850?

        diff --git a/arch/arm/mach-davinci/da850.c
        b/arch/arm/mach-davinci/da850.c
        index 63916b9..ebc8700 100644
        --- a/arch/arm/mach-davinci/da850.c
        +++ b/arch/arm/mach-davinci/da850.c
        @@ -238,6 +238,12 @@ static struct clk tptc2_clk = {
               .flags          = ALWAYS_ENABLED,
         };

        +static struct clk pru_clk = {
       +       .name       = "pru_ck",

      We don't add _ck postfixes in DaVinci code.

[SG] -- Will change to pruss_clk

   We don't add postfixes at all, so just "pruss".

        @@ -542,7 +549,12 @@ static const struct mux_config da850_pins[] = {
MUX_CFG(DA850, EMA_CLK, 6, 0, 15, 1, false) MUX_CFG(DA850, EMA_WAIT_1, 6, 24, 15, 1, false) MUX_CFG(DA850, NEMA_CS_2, 7, 0, 15, 1, false)
        +       /* PRU functions for soft CAN */
        +       MUX_CFG(DA850, PRU0_R31_0,      7,      28,     15, 0,
         false)
        +       MUX_CFG(DA850, PRU1_R30_15,     12,     0,      15, 4,
         false)
        +       MUX_CFG(DA850, PRU1_R31_18,     11,     20,     15, 0,
         false)

      Still not properly aligned.

[SG] -- This is only occurring with the emails, the original patch does not have them. I am a newbie to open source, please let me know if I am doing something wrong.

Perhaps you should use 'git send-email' to send the patches, so that they don't get spoiled. Ah, I've just looked at your mail again and realized that you already use it. Then I really don't know -- your following line (adding GPIO2[0]) looks properly aligned...

WBR, Sergei

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to