Hello. On Wed, Dec 1, 2010 at 5:12 PM, Sergei Shtylyov <[email protected]>wrote:
> Hello. > > On 01-12-2010 12:05, Subhasish Ghosh wrote: > > Not sure why you mention DA850 EVM in the subject -- this patch doesn't > touch it. [SG] -- Should I mention it as "davinci: ". > > > The patch adds support for the programmable realtime unit (PRU) >> available on OMAPL138. This defines the system resource >> requirements such as pin mux, clock, iomem, interrupt etc >> and registers the platform device >> > > It registers CAN platfrom device, not just PRU, right? [SG] -- It only registers CAN. Will modify the comments as below: The patch adds support for an emulated CAN controller on the programmable realtime unit (PRU) available on OMAPL138. This defines the system resource requirements such as pin mux, clock, iomem, interrupt etc and registers the platform device as per the Linux driver model. > > > as per the Linux driver model. >> > > Signed-off-by: Subhasish Ghosh<[email protected]> >> > > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c >> index 63916b9..ebc8700 100644 >> --- a/arch/arm/mach-davinci/da850.c >> +++ b/arch/arm/mach-davinci/da850.c >> @@ -238,6 +238,12 @@ static struct clk tptc2_clk = { >> .flags = ALWAYS_ENABLED, >> }; >> >> +static struct clk pru_clk = { >> + .name = "pru_ck", >> > > We don't add _ck postfixes in DaVinci code. [SG] -- Will change to pruss_clk > > > @@ -542,7 +549,12 @@ static const struct mux_config da850_pins[] = { >> MUX_CFG(DA850, EMA_CLK, 6, 0, 15, 1, >> false) >> MUX_CFG(DA850, EMA_WAIT_1, 6, 24, 15, 1, >> false) >> MUX_CFG(DA850, NEMA_CS_2, 7, 0, 15, 1, >> false) >> + /* PRU functions for soft CAN */ >> + MUX_CFG(DA850, PRU0_R31_0, 7, 28, 15, 0, false) >> + MUX_CFG(DA850, PRU1_R30_15, 12, 0, 15, 4, false) >> + MUX_CFG(DA850, PRU1_R31_18, 11, 20, 15, 0, false) >> > > Still not properly aligned. [SG] -- This is only occurring with the emails, the original patch does not have them. I am a newbie to open source, please let me know if I am doing something wrong. > > > /* GPIO function */ >> + MUX_CFG(DA850, GPIO2_0, 6, 28, 15, 8, >> false) >> > > Addition of the GPIO pin should probably be the patch of its own, since > it's done in the interests of EVM board, not being a PRU pin... [SG] -- Will add a separate patch for the GPIO. > > > diff --git a/arch/arm/mach-davinci/devices-da8xx.c >> b/arch/arm/mach-davinci/devices-da8xx.c >> index 9eec630..9d1b110 100644 >> --- a/arch/arm/mach-davinci/devices-da8xx.c >> +++ b/arch/arm/mach-davinci/devices-da8xx.c >> @@ -85,6 +85,35 @@ struct platform_device da8xx_serial_device = { >> > [...] > >> +/* Info specific to CAN conroller */ >> >> +static struct platform_device omapl138_pru_can_device = { >> + .name = "davinci_pru_can", >> + .id = -1, >> > > Please align. > > + .num_resources = ARRAY_SIZE(omapl138_pru_can_resources), >> >> + .resource = omapl138_pru_can_resources, >> +}; >> > [...] > > diff --git a/arch/arm/mach-davinci/include/mach/da8xx.h >> b/arch/arm/mach-davinci/include/mach/da8xx.h >> index 4247b3f..3e88676 100644 >> --- a/arch/arm/mach-davinci/include/mach/da8xx.h >> +++ b/arch/arm/mach-davinci/include/mach/da8xx.h >> > [...] > > @@ -122,6 +123,7 @@ extern const short da850_uart2_pins[]; >> extern const short da850_i2c0_pins[]; >> extern const short da850_i2c1_pins[]; >> extern const short da850_cpgmac_pins[]; >> +extern const short da850_pru_can_pins[]; >> > > You forgot to delete this. > [SG] -- Will remove this. > > WBR, Sergei >
_______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
