On Thu, 2009-09-17 at 11:20 +0200, Emanuele Aina wrote: > Jonathan Pryor applicò: > > > > Do not require a separate Storage when updating referenced objects. > > > > This doesn't apply against trunk r1218. > > Resending, this time in the body. > > If you prefer, I can also attach the patch gzipped to avoid end-of-line > mismatches.
Inserting into the body does no good (won't preserve end-of-line characters). And to further debug this I've done a git-svn checkout, created a patch, and emailed through Evolution. Your suspicion is correct -- Evolution is changing the EOL characters in the attached patch! (Which effectively makes Evolution *useless* for sending patches on DOS formatted files. I did not know this.) So in the future, you should gzip patches before attaching (hopefully that'll work). As for this particular patch, it looks sane, but I have only one more request: presumably you did this to avoid a NullReferenceException. What were you doing to get this error? You should add a unit test that provokes the error (thus demonstrating that the fix is correct, and preventing us from breaking that behavior in the future). Thanks, - Jon --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
