On Thu, 2009-09-17 at 21:16 +0200, Emanuele Aina wrote: > Jonathan Pryor confermò: > > > So in the future, you should gzip patches before attaching (hopefully > > that'll work). > > To ease review, should I also insert the patch in the body of the email?
Either attach it (resulting in two attachments, the .patch and .patch.gz), or inline it -- whichever is easiest. > > You should add a unit test that provokes the error (thus demonstrating > > that the fix is correct, and preventing us from breaking that behavior > > in the future). > > Do you prefer having the testcase and the fix 1) in the same patch, 2) > the (failing) testcase first or 3) the fix first? I prefer having the test case & the fix in the same patch (thus allowing me to verify that the fix). Thanks, - Jon --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
