Jonathan Pryor confermò: > So in the future, you should gzip patches before attaching (hopefully > that'll work).
To ease review, should I also insert the patch in the body of the email? > As for this particular patch, it looks sane, but I have only one more > request: presumably you did this to avoid a NullReferenceException. > What were you doing to get this error? It was the case of an EntitySet marked as Association without specifying the Storage property. It was all well until DbLinq tried to populate the EntitySet using only the Storage setting, which in my case was not set. It does not happen on DbMetal-generated files as they always have explicit Storage for each property, but DbLinq should work even without those. > You should add a unit test that provokes the error (thus demonstrating > that the fix is correct, and preventing us from breaking that behavior > in the future). Do you prefer having the testcase and the fix 1) in the same patch, 2) the (failing) testcase first or 3) the fix first? -- Emanuele Aina Studio Associato Di Nunzio e Di Gregorio http://dndg.it/ Via Maria Vittoria, 2 10123 Torino - Italy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DbLinq" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/dblinq?hl=en -~----------~----~----~----~------~----~------~--~---
