Hello Luk, On Mon, Jun 8, 2009 at 6:17 PM, Luk Claes<[email protected]> wrote: > Attached is a first try to support udhcpc in netcfg.
Thank you very much by working on it. > I opted for dropping support for pump and the ISC dhcp client, though > that could be reverted if really wanted. I'd much prefer to have as an extra option in this moment, instead of droping them. It makes the diff easier to be reviewed and also allow us to have them as fallback in case we find any serious regression and also allows for easier testing. A small thing I've noticed is that you've not kept the code using same coding style it had. Please split the structure initializators and try to leave the coding style as near as possible from current one. Again, thanks a lot about looking at it. Don't take this as a critic but more as a small set of suggestions to avoid problems and allow us to improve it as fast as possible. Cheers, -- Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
