Otavio Salvador wrote: > Hello Luk, Hi Otavio
> On Mon, Jun 8, 2009 at 6:17 PM, Luk Claes<[email protected]> wrote: >> Attached is a first try to support udhcpc in netcfg. > > Thank you very much by working on it. > >> I opted for dropping support for pump and the ISC dhcp client, though >> that could be reverted if really wanted. > > I'd much prefer to have as an extra option in this moment, instead of > droping them. > > It makes the diff easier to be reviewed and also allow us to have them > as fallback in case we find any serious regression and also allows for > easier testing. > > A small thing I've noticed is that you've not kept the code using same > coding style it had. Please split the structure initializators and try > to leave the coding style as near as possible from current one. That would be rather hard as the way you can specify options is very different than what pump or dhcp3 use. For udhcp everything has to be specified explicitly on the command line repeating the option specifiers AFAICS. I also think that having the fall back at the cost of more complex code is suboptimal as we can always revert the commit when really needed. Cheers Luk -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
