On 1.7.2020 11.57, Jörg Behrmann wrote: > On 01.07.20 09:14, Timo Aaltonen wrote: >> I'm not doing this, instead I'll add DEBUG_LOGGER template to >> /etc/default/sssd and mention that DAEMON_OPTS is only used for the >> initscript. >> > > I would like to argue, that the total removal of the coupling of the > service file and /etc/defaults/sssd might be the better way forward. > > The current state is that /etc/defaults/sssd has no effect on > sssd.service. I don't think it's a good idea to introduce it now, since > it's a hidden layer of configuration that cannot be accessed via > `systemctl cat`. > > It's perfectly fine for init scripts to use /etc/defaults, as there is > no better mechanism to alter configuration, but for systemd unit files > drop-ins are far superior, since `systemctl cat` aggregates them, > shifting the burden of piecing together the configuration away from admins. > > Furthermore, using drop-ins in /lib/systemd/system/sssd.service.d would > allow to carry Debian changes to the default config in files that could > be changed atomically on updates without interfering with locally > supplied changes.
Feel free to suggest that upstream then, they still use sysconfig for the daemon configuration, and expect us to have /etc/default/sssd, as shown in the commit that introduced DEBUG_LOGGER: commit a7277fecf7a65ab6c83b36f009c558cdfbf997d2 Author: Lukas Slebodnik <[email protected]> Date: Mon Oct 23 18:03:46 2017 +0200 SYSTEMD: Replace parameter --debug-to-files with ${DEBUG_LOGGER} Users can set variable DEBUG_LOGGER in environment files (/etc/sysconfig/sssd or /etc/default/sssd; depending on the distribution) to override default logging to files. e.g. DEBUG_LOGGER=--logger=stderr DEBUG_LOGGER=--logger=journald Resolves: https://pagure.io/SSSD/sssd/issue/3433 -- t
signature.asc
Description: OpenPGP digital signature
