On 15.5.2020 12.43, Jörg Behrmann wrote: > Package: sssd > Version: 1.16.3-3.2 > Severity: normal > Tags: patch > > The service file for sssd seems to be the upstream one, but on Debian it has > some minor issues: > > 1. PIDFile is set to /var/run/sssd.pid via PIDFile=@pidpath@/sssd.pid during > the > build, but systemd-analyze complains > > /lib/systemd/system/sssd.service:13: PIDFile= references a path below > legacy directory /var/run/, updating /var/run/sssd.pid → /run/sssd.pid; > please update the unit file accordingly. > > The path is automatically updated, but it does produce unnecessary logspam. > > The configure script seems to have an option --with-pid-path to change > this.
this is done in git > 2. The EnvironmentFile is set to -/etc/default/sssd, but said file says that > it > is only used for /etc/init.d/sssd and its DAEMON_OPTS, that are thankfully > unused in the service file, would daemonize sssd in contradiction to the > explicit foreground option in ExecStart and also use the deprecated > --debug-to-files option (via its shorthand -f). > > It would be best to just remove the line, although this would need to be > done > in all sssd service files. > > 3. The DEBUG_LOGGER environment variable should be unnecessary, when all sssd > services are socket activated, and --logger could be set on the ExecStart > line, making the configuration clearer. > > Attached is how the sssd.service file could look. I do understand, though, > that > all the service files for the socket activated mode of service would need to > be > changed as well. I would do the busy work if needed. I'm not doing this, instead I'll add DEBUG_LOGGER template to /etc/default/sssd and mention that DAEMON_OPTS is only used for the initscript. -- t
