Quoting Junyong Liang (2026-06-19 15:29:23) > I have rebased my work on top of your latest fix and completed the > source package split. > > Now, |hx|source provides a new |hx-plugin-dev|package, and > |hx-grammars|source depends on this package to perform source updates. > After the source update step, the build produces two binary packages: > |hx-highlight-core|and |hx-highlight-extra|. > > I have tested the packaging on my machine and the build completes > successfully. > > I have also pushed the changes to my Salsa repositories: > > * https://salsa.debian.org/Junyong-Liang/hx > <https://salsa.debian.org/Junyong-Liang/hx> > * https://salsa.debian.org/Junyong-Liang/hx-grammars > <https://salsa.debian.org/Junyong-Liang/hx-grammars>
I have only looked at the changes to the src:hx this time around - i.e. not looked at src:hx-grammars at all (not because I don't care, but because I am finishing a bachelor study - last oral exam on June 29th, and I try limit how much this exciting distraction steals my attention) It looks quite good now. A few remarks, though: Please rebase to only commit stuff that is actually used at the end. E.g. currently you introduce a gigantic amount of code and then drop it again - while that is beneficial to document your thought process, it is confusing and a waste of disk space for those who need not track *how* you ended up at the final set of code changes. The ABI helper script computes a hash every time it is run. Maybe that's fine, but perhaps it makes better sense to compute it once during build, since the files involved are statically available at build time. You drop lintian overrides, but it seems they are still needed. I have not actually tested if lintian spews warnings if removed, I just notice that the mentioned licenses are still listed in the debian/copyrrght file. Kind regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ * Sponsorship: https://ko-fi.com/drjones [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
