Hi Jonas,
Thank you very much for your review and suggestions.
I have addressed all of the points you mentioned:
* rebased the branch to keep only the final relevant commits,
* moved the ABI hash generation to build time,
* restored the necessary lintian overrides.
Please take another look when you have time.
Good luck with your final oral exam, and I look forward to hearing your
feedback once you're finished.
Best regards,
Junyong Liang
On 2026/6/20 14:51, Jonas Smedegaard wrote:
Please rebase to only commit stuff that is actually used at the end.
E.g. currently you introduce a gigantic amount of code and then drop it
again - while that is beneficial to document your thought process, it
is confusing and a waste of disk space for those who need not track
*how* you ended up at the final set of code changes.
The ABI helper script computes a hash every time it is run. Maybe
that's fine, but perhaps it makes better sense to compute it once
during build, since the files involved are statically available at
build time.
You drop lintian overrides, but it seems they are still needed. I have
not actually tested if lintian spews warnings if removed, I just notice
that the mentioned licenses are still listed in the debian/copyrrght
file.
Kind regards,
- Jonas
