On Sun, Jun 29, 2008 at 4:07 PM, Artur R. Czechowski <[EMAIL PROTECTED]> wrote: > Hi there, > > I just prepared QGLViewer linked with QT4. It is uploaded to > mentors.debian.net and it's waiting for sponsor. If you wish > to check the package before it will be available in Debian you can > fetch the source from > http://mentors.debian.net/debian/pool/main/l/libqglviewer/ > > Any comments highly appreciated.
Sure, here are 5 comments 1) Original tarball and diff directory names don't match... Your orig tarball extracts to libQGLViewer-2.2.6-3 while the patch expects libqglviewer-2.2.6-3 . 2) Patches should not be executable. Please "chmod a-x" all your patches. 3) Shouldn't you remove the dependency on libgl1-mesa-dev at all? I think this is at the root of the dependency on an obsolete package: xlibmesa-gl. Two Lintian warnings: E: libqglviewer-qt4-2: depends-on-obsolete-package depends: xlibmesa-gl E: libqglviewer-qt3-2: depends-on-obsolete-package depends: xlibmesa-gl 4) Is there really a need to keep the qt3 version in there? 5) Please consider renaming libqglviewer-qt4-2 to libqglviewer2. It will make it easier to upgrade seamlessly and reduce propagation time to debian archives. If you wanted to make it explicit that it's for qt4, you may want to create a dummy package... Cheers, -Pascal -- Homepage (http://organact.mine.nu) Debian GNU/Linux (http://www.debian.org) LACIME: École de technologie supérieure (http://lacime.etsmtl.ca) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
