Hi, On Sun, 10 Jan 2010, Modestas Vainius wrote: > Remote branch [1] has been updated. Notes:
I cleaned up your branch and added some changes of mine, it's here: http://git.debian.org/?p=users/hertzog/dpkg.git;a=shortlog;h=refs/heads/pu/symbol-patterns I squashed some small fixes in some of your commits (small typos in the man page, and a bug in save_load_test()), I hope you don't mind. Feel free to review. I'm going to merge this soon if you don't see any problem. > * readline() cannot be replaced with <> easily due to trickiness in perl > syntax. Perl does not like anything but <$simplevar> and we need <$hash- > >{key}> here. $hash->{key}->getline() would still be nicer IMO but not a big deal, I see we use readline() at 2 other places in the code... > * Double "exists" in is_optional() is needed to avoid creation of redundant > {pattern} hash. Otherwise, "save -> load" tests would fail. {old_wildcard} is > under {pattern} due to how create_pattern_match() eliminates pattern > properties. I dropped old_wildcard and the changes in is_optional() in the last commit. Cheers, -- Raphaël Hertzog -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
