On Mon, 11 Jan 2010, Modestas Vainius wrote: > > Feel free to review. I'm going to merge this soon if you don't see any > > problem. > > You will need testsuite-fix.diff patch to make the code pass the testsuite. I > suggest --amend it to your old-style wildcards commit because the later > changed cosmetic behaviour a bit (save_load_test() fails because diff is no > longer the same due to wildcards etc.)
Oops... applied but with another fix, it contains 106 tests not 105. > In addition (save_load_test_shifts.diff), double "shift"s are back in > save_load_test() because @_ is later passed to save() call. I don't know how > you prefer to handle this type of cases in your style though. my($a, $b, %opts) = @_; and then pass along %opts where wanted (or @opts if it's not hash-like options). > Otherwise, full ACK from me. Ok, merged. Cheers, -- Raphaël Hertzog -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
