I'm looking over the stack of patches you sent for debmirror earlier. default-settings.patch:
* rsync batching size: I see no problem with it, but rsync batching was added after I wrote debmirror, and I don't understand why it's needed anyway * no motd: probably ok; the motd could perhaps be displayed on the first rsync call and not subsequent ones * removing -I flag: Was also added after I wrote debmirror. Seems ok to remove to me, but I am curious how it's "troublesome". * stdout auto-flushing: only needed if something writes to stdout without \n, which nothing seems to? silence-errors.patch: Before silencing any errors I always like to think about how the error could occur. So, is there any case where the find calls fail with an error, that is not itself an error? functionalize.patch: applied to my 'patchy' branch in my debmirror git repo (git://git.debian.org/collab-maint/debmirror.git) drop-redundant-rsync.patch: Seems probably ok, but I think I need to understand why the rsync code is so complicated by batching, etc first. check_file-return.patch Won't this result in a *lot* of spew about "Missing: $file" when starting a fresh mirror in verbose mode? command-exit-checking.patch applied to my 'patchy' branch in my debmirror git repo. -- see shy jo
signature.asc
Description: Digital signature
