Hi Joey, On Mon, Sep 06, 2010 at 06:51:00PM -0400, Joey Hess wrote: > I'm looking over the stack of patches you sent for debmirror earlier. > > default-settings.patch: > > * rsync batching size: I see no problem with it, but rsync > batching was added after I wrote debmirror, and I don't > understand why it's needed anyway
I'm not sure either, but it's possible that some servers may not allow long-running connections. > * no motd: probably ok; the motd could perhaps be displayed > on the first rsync call and not subsequent ones True, but I suspect it has actually no real value -- the selected server is already known to the user, etc. > * removing -I flag: Was also added after I wrote debmirror. > Seems ok to remove to me, but I am curious how it's "troublesome". Honestly, I've forgotten now, but I think it was missing files sometimes. > * stdout auto-flushing: only needed if something writes > to stdout without \n, which nothing seems to? This may have been related to debugging work I was doing. Or it was related to trying to synchronize perl's output with subprocess output. > silence-errors.patch: > > Before silencing any errors I always like to think about > how the error could occur. So, is there any case where the find > calls fail with an error, that is not itself an error? Yes, there are a number of cases where it's just looking for things existing or not, and it would complain loudly for newly added repos, IIRC. > functionalize.patch: > > applied to my 'patchy' branch in my debmirror git repo > (git://git.debian.org/collab-maint/debmirror.git) Thanks! > drop-redundant-rsync.patch: > > Seems probably ok, but I think I need to understand why the rsync > code is so complicated by batching, etc first. Sure, though I think this is a pretty clear win for simplifying that loop. > check_file-return.patch > > Won't this result in a *lot* of spew about "Missing: $file" > when starting a fresh mirror in verbose mode? Yes, but that's what you'd want in verbose mode, right? > command-exit-checking.patch > > applied to my 'patchy' branch in my debmirror git repo. Thanks! -Kees -- Kees Cook @debian.org -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
