Kees Cook wrote: > > * rsync batching size: I see no problem with it, but rsync > > batching was added after I wrote debmirror, and I don't > > understand why it's needed anyway > > I'm not sure either, but it's possible that some servers may not allow > long-running connections.
Guess so. It could reconnect if a sever dropped a connection though. May need to ask mrvn, who added it, for the reason. > > * no motd: probably ok; the motd could perhaps be displayed > > on the first rsync call and not subsequent ones > > True, but I suspect it has actually no real value -- the selected server is > already known to the user, etc. I guess two things I've seen rsync motds used for are a) this is the cool entity who provides this bandwidth b) actual policy / news stuff for the server Maybe it should only be shown, once, in verbose mode? > > * removing -I flag: Was also added after I wrote debmirror. > > Seems ok to remove to me, but I am curious how it's "troublesome". > > Honestly, I've forgotten now, but I think it was missing files sometimes. Well, -I *avoids* skipping files that have the same size and time, so *removing* it could, in theory, cause bad files to be kept, but I don't see how keeping it and doing more checks could. > > Before silencing any errors I always like to think about > > how the error could occur. So, is there any case where the find > > calls fail with an error, that is not itself an error? > > Yes, there are a number of cases where it's just looking for things > existing or not, and it would complain loudly for newly added repos, IIRC. Hmm, I have been running debmirror for a week building a new repo, and have not seen a find error yet.. > > check_file-return.patch > > > > Won't this result in a *lot* of spew about "Missing: $file" > > when starting a fresh mirror in verbose mode? > > Yes, but that's what you'd want in verbose mode, right? I dunno, all I want in verbose mode is an indication of what it's downloading, and maybe some progress info. I can guess that it's downloading the file because it's not present, that seems to obvious to say. (I did like the part of the patch that said when it had to download an existing file for some other reason.) -- see shy jo
signature.asc
Description: Digital signature
