Hi Xiyue,

* I would suggest making the source package name `emacs-pangu-spacing'.
>   The Emacsen wiki[1] suggests only adding "emacs-" prefix or "-el" suffix
> if
>   the name is too generic, though I do think it would be beneficial to
>   make it clear that this is Emacs related.

I updated both the salsa's project name and package name to
`emacs-pangu-spacing`.

* I would suggest running dh-make-elpa on a clean upstream repo to start
>   from a clean state would help avoid many of the residuals from the
>   default templates from dh-make.

I see. I pushed the only debianised commit to debian/master branch.

Can I work on the build issue?

Best regards,

2025年12月10日(水) 14:59 Xiyue Deng <[email protected]>:

> Hi Obinata-san,
>
> Yoshiki Obinata <[email protected]> writes:
>
> > Hi, Deng-san!
> >
> > Thank you for your response.
> >
> > Regarding the Debian packaging, I would suggest checking out the
> >> dh-make-elpa tool[1], which will provide a sensible default for most of
> >> the debian packaging files for an Emacs addon.  The details can be found
> >> in its manpage ("man dh-make-elpa") which also contains a typical usage
> >> example for working on a new Emacs addons which I find very useful.
> >> Also checkout the Debian Emacsen team wiki[2] for more info.
> >
> > Thank you. I'll check it. Maybe using dh-make-elpa is the best way to
> > debianize.
> >
> > Meanwhile, as most of the Debian Emacs addons are maintained on
> >> Salsa[3], would you be interested in moving the packaging work there as
> >> well?
> >
> > Yes!
> > I have the salsa account. The ID is @mqcmd196.
> > https://salsa.debian.org/mqcmd196
> >
>
> I saw that you added me as a developer to your repo.  Thanks!  I have a
> few generic comments before giving a detailed review:
>
> * I would suggest making the source package name `emacs-pangu-spacing'.
>   The Emacsen wiki[1] suggests only adding "emacs-" prefix or "-el" suffix
> if
>   the name is too generic, though I do think it would be beneficial to
>   make it clear that this is Emacs related.
>
> * I would suggest running dh-make-elpa on a clean upstream repo to start
>   from a clean state would help avoid many of the residuals from the
>   default templates from dh-make.
>
> I think we can consider moving the repo to the Emacsen team once the
> source package name is settled.
>
> [1] https://wiki.debian.org/Teams/DebianEmacsenTeam
>
> > This is my first time contributing to the Debian team. Maybe I'll ask
> some
> > questions.
> >
> > Best, regards
> >
> > 2025年12月8日(月) 10:36 Xiyue Deng <[email protected]>:
> >
> >> Hi Obinata-san,
> >>
> >> Yoshiki Obinata <[email protected]> writes:
> >>
> >> > Package: wnpp
> >> > Severity: wishlist
> >> >
> >> > * Package name : elpa-pangu-spacing
> >> > Version : 0.4.0
> >> > Upstream Author : Yen-Chin Lee <[email protected]>
> >> > * URL : https://github.com/coldnew/pangu-spacing
> >> > * License : GPL v3
> >> > Description : pangu-spacing-mode is an minor-mode to auto add space
> >> between
> >> > Chinese and English characters.
> >> >
> >> > I've already pushed the initial Debian commit to my local branch.
> >> > https://github.com/mqcmd196/pangu-spacing/tree/debian
> >> >
> >>
> >> Thanks for your interest in adding this package to Debian!  I find it a
> >> very useful minor-mode as a Chinese.
> >>
> >> Regarding the Debian packaging, I would suggest checking out the
> >> dh-make-elpa tool[1], which will provide a sensible default for most of
> >> the debian packaging files for an Emacs addon.  The details can be found
> >> in its manpage ("man dh-make-elpa") which also contains a typical usage
> >> example for working on a new Emacs addons which I find very useful.
> >> Also checkout the Debian Emacsen team wiki[2] for more info.
> >>
> >> Meanwhile, as most of the Debian Emacs addons are maintained on
> >> Salsa[3], would you be interested in moving the packaging work there as
> >> well?
> >>
> >> [1] https://tracker.debian.org/pkg/dh-make-elpa
> >> [2] https://wiki.debian.org/Teams/DebianEmacsenTeam
> >> [3] https://salsa.debian.org/emacsen-team
> >>
> >> > --
> >> > /********************************************
> >> > * Yoshiki Obinata (大日方 慶樹)
> >> > * JSK Robotics Lab, The Univ. of Tokyo
> >> > ********************************************/
> >>
> >> --
> >> Regards,
> >> Xiyue Deng
> >>
> >
> >
> > --
> > /********************************************
> > * Yoshiki Obinata (大日方 慶樹)
> > * JSK Robotics Lab, The Univ. of Tokyo
> > ********************************************/
>
> --
> Regards,
> Xiyue Deng
>


-- 
/********************************************
* Yoshiki Obinata (大日方 慶樹)
* JSK Robotics Lab, The Univ. of Tokyo
********************************************/

Reply via email to