Hi Yoshiki, Yoshiki Obinata <[email protected]> writes:
> Hi Xiyue, > > Obinata-san, please feel free to change it back to "pangu-spacing" if >> you prefer, and sorry for the trouble. > > I don't have any strong opinion to add emacs- prefix or not. Anyway, I > switched back to pangu-spacing. Please check. > > Best regards, > I saw that the project has now been moved under emacsen-team on Salsa. I have left a few comments on your commit. Let me know if you have any questions. > 2025年12月11日(木) 10:43 Xiyue Deng <[email protected]>: > >> Sean Whitton <[email protected]> writes: >> >> > Hello, >> > >> > On Wed 10 Dec 2025 at 07:29am -08, Xiyue Deng wrote: >> > >> >> Hi Sean, >> >> >> >> Sean Whitton <[email protected]> writes: >> >> >> >>> Hello, >> >>> >> >>> On Tue 09 Dec 2025 at 09:56pm -08, Xiyue Deng wrote: >> >>> >> >>>> I saw that you added me as a developer to your repo. Thanks! I have >> a >> >>>> few generic comments before giving a detailed review: >> >>>> >> >>>> * I would suggest making the source package name >> `emacs-pangu-spacing'. >> >>>> The Emacsen wiki[1] suggests only adding "emacs-" prefix or "-el" >> suffix if >> >>>> the name is too generic, though I do think it would be beneficial to >> >>>> make it clear that this is Emacs related. >> >>> >> >>> I think it should be just pangu-spacing unless this terminology "pangu" >> >>> is something people generally use outside of an Emacs context (IHNI). >> >>> >> >> >> >> Pangu is a god in Chinese mythology (see more in [1]) and I believe he >> >> is well known in Chinese speaking (or maybe even other Asian) countries. >> >> I think adding the "emacs-" prefix would make it more explicit that this >> >> package is emacs related, or people will need to jump through hoops to >> >> find its relation. >> > >> > Source package names should be more about respecting upstream's choices, >> > I think. Binary package names make it easy to find out. >> >> I found it helps in some cases if source package names gives good hints >> on its connection to Emacs, but as you said the binary package will be >> prefixed with "elpa-" anyway it may be good enough for searching >> purpose. Though I would still like to see the source package prefixed >> with "emacs-", I won't insist on it. >> >> Obinata-san, please feel free to change it back to "pangu-spacing" if >> you prefer, and sorry for the trouble. >> >> > >> > -- >> > Sean Whitton >> >> -- >> Regards, >> Xiyue Deng >>
signature.asc
Description: PGP signature
