Thanks Simon for the quick review!

El martes, 5 de mayo de 2026 a las 09:41, Simon Josefsson <[email protected]> 
escribió:

> golang-github-kelindar-simd and golang-github-kelindar-bitmap:


Maytham just recently helped to move the repos to the go-team workspace.

https://salsa.debian.org/go-team/packages/golang-github-kelindar-simd/
https://salsa.debian.org/go-team/packages/golang-github-kelindar-bitmap/
https://salsa.debian.org/go-team/packages/siso/


 
> - decide whether to use pristine-tar or not: gbp.conf says it is used,
>   but there is no pristine-tar branches on Salsa

Updated gbp.conf to match.
 
> - for golang-github-kelindar-simd, push the upstream/1.2.0 tag

Done
 
> - Add to d/copyright 'Roman Atachiants and contributors' 

Done

> - The *.go file seems auto-generated, shouldn't they be re-generated by
>   the codegen/ tooling?

Good catch. I had a deeper look. Those auto-generated .go and .s files are 
committed upstream as canonical source. Author seems to be using gocc 
(currently unpackaged). Since this can be considered a upstream helper tool, 
not needed for packaging. 
In addition, the author has gocc invocations commented out in 
codegen/generate.sh. Let me know your thoughts. 

This has been documented in debian/README.source.


> - I would drop debian/.gitignore for tag2upload --quilt=unapplied
>   compatibility.


Removed

Leaving CI .yaml for now.  I want to improve/use them over time unless the team 
prefer it is not advisable.

> Otherwise ready for upload, and I could sponsor these nobody else does
> it before me.  I could look at 'siso' too later, if needed, but the
> above two packages needs to be in the archive first.

I would be honored! Even if it is not my first packaged being sponsored, this 
is the one with less dependencies and the highest chances of passing ftp-master 
review :D

BTW, siso is a Chromium team request, and I am helping in some tasks, so they 
will be very glad. 

Thanks,

Juan

Reply via email to