El miércoles, 6 de mayo de 2026 a las 13:49, Simon Josefsson 
<[email protected]> escribió:

> I had a look at siso but building fails:
> 

> https://salsa.debian.org/jas/siso/-/jobs/9545332

Good finding. Since I am packaging this to support a Debian Chromium need, I am 
doublechecking that siso builds for the same architectures that Debian Chromium 
supports.

I am looking at this now, will report back when ready.

 

> I think the package generally looks good, but I didn't look closely at
> the vendoring/copyright situation.

I doublechecked, and have used lrc and licensecheck and did not find any 
lintian complaint. Hopefully it is ready for ftp master review.


> - Use dh-sequence-golang, not dh-golang

Using dh-sequence-now in Build-Depends and dh in rules.


> - Is a golang-*-dev package relevant?  Sometimes other packages end up 
> depending on the library part of CLI tools.

Good question, it should be only binary used for chromium infrastructure. Using 
now: dh_auto_install -- --no-source


> - Consider using execute_after_dh_auto_configure instead of
>   override_dh_auto_configure.

Changed.

> - Why is override_dh_auto_build needed?  Is it the -buildmode=pie?  Is
>   that required, or just a nice thing?  Don't we have any other
>   mechanism to enable PIE builds?  Seems like a useful hardening
>   technique generally.


I don't know if there is other Debian mechanism to use it. I am happy to remove 
if the team preference is having simplified rules. Although it's a nice to have 
for hardening executables.


> - In override_dh_auto_test, why doesn't dh_auto_test do the right thing
>   automatically?

Unnecessary, removed


> - Consider execute_after_dh_installdocs instead of
>   override_dh_installdocs.

Changed
 

> - Where is debian/siso.1 coming from?  It looks auto-generated, so
>   either should be generated during build, or preferably, somehow
>   upstreamed rather than being a Debian-specific man page.  I've used
>   help2man from debian/rules in several packages.

I switched to help2man with a siso.h2m. 

Attachment: publickey - [email protected] - 0xE697CF1F.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to