With golang-github-kelindar-{simd,bitmap} uploaded, I had a look at siso
but building fails:https://salsa.debian.org/jas/siso/-/jobs/9545332 I think the package generally looks good, but I didn't look closely at the vendoring/copyright situation. Some random nits: - Use dh-sequence-golang, not dh-golang - Is a golang-*-dev package relevant? Sometimes other packages end up depending on the library part of CLI tools. - Consider using execute_after_dh_auto_configure instead of override_dh_auto_configure. - Why is override_dh_auto_build needed? Is it the -buildmode=pie? Is that required, or just a nice thing? Don't we have any other mechanism to enable PIE builds? Seems like a useful hardening technique generally. - In override_dh_auto_test, why doesn't dh_auto_test do the right thing automatically? - Consider execute_after_dh_installdocs instead of override_dh_installdocs. - Where is debian/siso.1 coming from? It looks auto-generated, so either should be generated during build, or preferably, somehow upstreamed rather than being a Debian-specific man page. I've used help2man from debian/rules in several packages. /Simon
signature.asc
Description: PGP signature
