Hi Andrei, On Tue, Oct 06, 2020 at 07:49:14PM +0200, Andrei Rozanski wrote: > > > https://salsa.debian.org/med-team/gjh-asl-json/-/blob/master/debian/patches/fix-makefile-lib.patch#L27 > Got it. Thanks!
OK. > > I've seen these patches. Regarding the lintian warning remaining: > > Well, sometimes there are false positives. I think we can ignore these. > > However, I enhanced your patch. It is more flexible to rely on the > > variables rather than hardcoding (for instance for cross building or > > things like this). > > I have seen that gjh_asl_json has a tests directory > https://github.com/ghackebeil/gjh_asl_json/tree/master/tests > > However, seeing the example of trf > https://salsa.debian.org/med-team/trf/-/blob/master/debian/control I may > need to install the tests files > > in a separate way as well? In trf the test data are way larger then in gjh-asl-json. I'd recommend to move these tests to /usr/share/doc/gjh-asl-json/examples (by creating a file debian/examples with the content tests/* and adapt run-unit-test to let something sensible happen. Kind regards Andreas. -- http://fam-tille.de
