Hi Andreas,
On 10/7/20 3:40 PM, Andreas Tille wrote:
Hi Andrei,
On Tue, Oct 06, 2020 at 07:49:14PM +0200, Andrei Rozanski wrote:
https://salsa.debian.org/med-team/gjh-asl-json/-/blob/master/debian/patches/fix-makefile-lib.patch#L27
Got it. Thanks!
OK.
I've seen these patches. Regarding the lintian warning remaining:
Well, sometimes there are false positives. I think we can ignore these.
However, I enhanced your patch. It is more flexible to rely on the
variables rather than hardcoding (for instance for cross building or
things like this).
I have seen that gjh_asl_json has a tests directory
https://github.com/ghackebeil/gjh_asl_json/tree/master/tests
However, seeing the example of trf
https://salsa.debian.org/med-team/trf/-/blob/master/debian/control I may
need to install the tests files
in a separate way as well?
Ok. I got it.
In trf the test data are way larger then in gjh-asl-json. I'd recommend
to move these tests to /usr/share/doc/gjh-asl-json/examples (by creating
a file debian/examples with the content
Ok. I have pushed it
https://salsa.debian.org/med-team/gjh-asl-json/-/blob/master/debian/examples#L1
tests/*
Tried to port the tests script into it
https://salsa.debian.org/med-team/gjh-asl-json/-/blob/master/debian/tests/run-unit-test
and add python as dependency
https://salsa.debian.org/med-team/gjh-asl-json/-/blob/master/debian/tests/control
and adapt run-unit-test to let something sensible happen.
Kind regards
Andreas.
The build finishes like:
I: gjh-asl-json: hardening-no-fortify-functions usr/bin/gjh_asl_json
W: gjh-asl-json: new-package-should-close-itp-bug
W: gjh-asl-json: manpage-has-useless-whatis-entry
usr/share/man/man1/gjh-asl-json.1.gz
W: gjh-asl-json: binary-without-manpage usr/bin/gjh_asl_json
However I have add
https://salsa.debian.org/med-team/gjh-asl-json/-/blob/master/debian/gjh-asl-json.1
and
https://salsa.debian.org/med-team/gjh-asl-json/-/blob/master/debian/manpages
.. not sure
Thanks!
Best
AndreiR
