On Sat, Jul 29, 2017 at 09:46:49PM +0200, Federico Brega wrote:
> 2017-07-29 19:34 GMT+02:00 Andrey Rahmatullin <w...@debian.org>:
> > * The package now depends on python3
> > Which package?
> It's both a build dependency and a runtime dependency of "cyclograph"
> the main binary package. The cyclograph-qt5 and cyclograph-gtk3 binary
> packages depend on cyclograph, so they all depend on python3.
> Please take a look at the new changelog and see if this is now clear.
It's better, but I would write it in this way:

- Switch to pybuild
- Add dh-python, python3-all, python3-setuptools to Build-Depends
- Switch the cyclograph package to Python 3

> > * The package now uses dh-python in combination with python3-setuptools
> > "in combination"?
> My understanding is that pybuild, provided by the dh-python package,
> needs the setuptools for python3
Why do you think pybuild needs setuptools? The package seems to build fine
without that B-D.

It seems you haven't run lintian:

I: cyclograph source: debian-pycompat-is-obsolete
I: cyclograph source: vcs-field-uses-insecure-uri vcs-git 
I: cyclograph source: vcs-field-not-canonical 
I: cyclograph source: vcs-field-uses-insecure-uri vcs-browser 
I: cyclograph source: vcs-field-not-canonical 
I: cyclograph source: quilt-patch-missing-description removeUpdatesCheck.diff
I: cyclograph source: quilt-patch-missing-description useOpenLayersPackage.diff
I: cyclograph source: testsuite-autopkgtest-missing
I: cyclograph source: debian-watch-file-is-missing
W: cyclograph-qt5: spelling-error-in-changelog upsteam upstream
I: cyclograph-qt5: unknown-field-in-control tag
I: cyclograph-qt5: desktop-entry-contains-encoding-key 
usr/share/applications/cyclograph-qt.desktop:3 Encoding
I: cyclograph-qt5: desktop-entry-lacks-keywords-entry 
W: cyclograph: spelling-error-in-changelog upsteam upstream
I: cyclograph: unknown-field-in-control tag
X: cyclograph: privacy-breach-generic usr/share/cyclograph/openlayers.html 
X: cyclograph: privacy-breach-generic usr/share/doc/cyclograph/manual.html 
W: cyclograph-gtk3: spelling-error-in-changelog upsteam upstream
I: cyclograph-gtk3: unknown-field-in-control tag
I: cyclograph-gtk3: desktop-entry-contains-encoding-key 
usr/share/applications/cyclograph-gtk3.desktop:3 Encoding
I: cyclograph-gtk3: desktop-entry-lacks-keywords-entry 
N: 2 tags overridden (2 warnings)

At least vcs-field-uses-insecure-uri, vcs-field-not-canonical and
spelling-error-in-changelog are caused by the changes in this upload, but
you should fix other problems too.

Why there is no separate section for debian/ in debian/copyright? Are the
copyright authors the same for it and the software itself?

You should fix the .desktop files. Currently having "python
/usr/bin/cyclograph" there is not just unneeded, it's wrong, as
/usr/bin/cyclograph is now using Python 3.

Priority should be optional, not extra.


Attachment: signature.asc
Description: PGP signature

Reply via email to