Ho Joel, thanks for your contribution !

Looking at your work there are a couple of things that can be improved:

1. I see that you set the Maintainer = Debian Javascript Maintainers.
   In that team normally we use git repos to keep track of the packaging; more 
precisely we use the git-buildpackage workflow.

2. All new repos nowadays are on salsa (https://salsa.debian.org), you can 
easily set up a guest account there with the self service webfrontend.

3. If you wish to maintain this package within this team, I'd suggest that you 
join the team !
   Just drop a mail to the mailing list committing to follow the team policies, 
and indicate your salsa alias.
   One of the js-team group owners can then add you to the group on salsa.

4. The Debian Javascript Maintainers keeps all repos in the js-team group on 
salsa (https://salsa.debian.org/js-team);
   after moving your repo there you can update the Vcs-Browser and Vcs-Git 
fields in debian/control.

5. I tried to build your package, at the end lintian complains about:
   - co-maintained-package-with-no-vcs-fields (see previous point)
   - out-of-date-standards-version 4.1.1 (current is 4.1.4)
   - insecure-copyright-format-uri 
   - package-uses-old-debhelper-compat-version 10 (current is 11)
   - json-editor.js source: source-contains-prebuilt-javascript-object 
dist/jsoneditor.min.js see last point

6. This library comes with examples, so you could install those too.
   You can patch the examples so that they load the jsoneditor.js file from the 
default location /javascript/... 
   which should point to /usr/share/javascript/... assuming apache2 alias from 
the javascript-common package is enabled ...

7. You are repackaging to exclude certain examples because they "link to 
libraries in external CDNs";
   Sctually it should be possible to patch them to use the system installed 
libraries (I checked examples/select2.html, we do have jquery and libselect2)
   (those additional libraries needed to enjoy the examples could be 
recommended by the package...)

8. It would be super cool if we could enable tests ... but I am not sure how 
(selenium ?)
   Tests can be run during package build and in the debian CI infrastructure 
which helps improve the quality of debian and to avoid mishaps when 
dependencies are updated;

9. You must repackage for sure: to exclude dist.
   Else the package will certainly be rejected by the ftp-masters: the dist 
directory should be re-created from source during the debian build.
   Unfortunately debhelper does not yet support building with grunt out of the 
box (https://bugs.debian.org/845043) so you have to manually add that to 
debian/rules, see:


Reply via email to