>For snd-cocoa.m, ui-effect.c, and ui-player-properties.c, I am interested in >documenting the copyright holders in >d/copyright (just saying "1989-2023 Angband contributors" is not enough).
Why is it not enough? Angband has 85 contributors listed on github alone, and many of the source files had dozens of additional contributors before they first appeared on github 13 years ago. Angband was released under GPL-2 in the late noughties (v3.1.0) and everyone contributing code since then has done so in the knowledge that Angband has a dual licence. To require contributors for these three files to be documented in d/copyright, but not the contributors to any other files, seems bizarre and disproportionate. >snd-win.h is licensed under BSD-2-clause (which is GPL-2 compatible), however, >the file misses the disclaimer which is >referred to in both clauses. Not including it means breaking the license >conditions. The same applies to other files: >src/sound.h, src/snd-sdl.h, src/message.c, src/message.h, src/z-textblock.c. >As I have mentioned, I had only looked at >the upstream diff, not all source files. These can be fixed by including the disclaimer, I will do that and offer the patch upstream. >main-ibm.c does not mention a GPL-2 option. The only license that is mentioned >is the Angband license which is not >DFSG-free. Upstream should make sure to mention GPL-2 as an alternative. This is a simple oversight - main-ibm.c was restored from a version prior to the dual licence. Again I will correct this and offer the patch upstream. Thanks Chris
