Hello Ana!

These look to be in good shape in general.  For the VCSs', you have two
options; if you want to join DPMT, you could put them under their
hierarchy, or you could use the Debian heirarchy and I can grant you
permissions for the repos.  Let me know which one you'd prefer to do.

I do have one tweak I'd like to see for python-tldextract; I think we
should have it Recommend `publicsuffix` and add that to the list of
PUBLIC_SUFFIX_LIST_URLs.  Please test it to make sure it works even without
that file; reading the code, it looks like it should, but I'd like to
double check.

For python-lexicon, it's generally considered good practice to use the same
license for the work under debian/ as the rest of the package is.  If the
difference was intentional, I'd want to know more about why you feel the
difference is important.

Let me know if you have questions; a couple of minor changes and I think
they're about ready to ship!

On Fri, Mar 2, 2018 at 7:37 PM, Ana C. Custura <a...@netstat.org.uk> wrote:

> Hi Harlan,
> Thank you for your email,  I've had some time to look at them and both are
> now on mentors:
> https://mentors.debian.net/package/tldextract
> https://mentors.debian.net/package/lexicon
> I would also like to push to salsa, but need help with getting access to
> repositories and/or teams. I've left the vcs fields pointing to
> salsa.debian.org/debian for now.
> Some notes:
> tldextract:
> -uses a writable cache file which ends up in usr/share  with the wrong
> permissions during the installation. I moved this to the user's homedir.
> lexicon:
> - some optional dependencies still need to be packaged to make some
> provider-specific functionality work; I filed ITPs for python3-pynamecheap
> and python3-transip [ #891944 and #891945 ]
> - it looks like tests fail with pybuild because they need to run from a
> specific directory,  so dh_auto_test is overridden with a custom command.
> All feedback is much appreciated, and thanks again!
> Ana
> On Sun, Feb 25, 2018, at 9:27 PM, Harlan Lieberman-Berg wrote:
> On Sun, Feb 25, 2018 at 16:06 Ana C. Custura <a...@netstat.org.uk> wrote:
> Thank you for the email!
> Yes I'm almost there with tldextract and I've partly packaged lexicon too,
> but forgot pick up the ITP for it.  I'm not a DD yet, so my for new
> packages I need a sponsor - would you like to be the one to review them and
> upload them?
> That’s awesome! I just took care of python-cloudflare last night, so
> that’s the list.
> Happy to sponsor them for you. Push them up to mentors and ping me when
> you’re ready!
> Sincerely,
> --
> Harlan Lieberman-Berg
> ~hlieberman

Harlan Lieberman-Berg

Reply via email to