On Mon 25/03/2024 at 23:40, David Christensen <[email protected]> wrote: > On 3/25/24 15:05, Gareth Evans wrote: >> On Fri 22/03/2024 at 21:01, Gareth Evans <[email protected]> wrote: >>> As anyone interested can see from the ref to #15933 in the below, there >>> seems to have been considerable effort in getting to grips with this bug >>> (actually multiple bugs), and it looks like a fix may be forthcoming, >>> though not sure at the time of writing if there may be some further >>> polishing first >>> >>> https://github.com/openzfs/zfs/pull/16019 >> >> https://github.com/openzfs/zfs/issues/15933 >> >> is now closed as completed with fix >> >> https://github.com/openzfs/zfs/commit/102b468b5e190973fbaee6fe682727eb33079811 >> >> which for the moment necessarily adds synchronous writes. >> >> FYI. >> Gareth > > > Thank you for keeping an eye on this. > > > Looking at the github commit, the C code makes me worry -- it does not > appear to use traditional C/C++ thread-safe programming techniques such > as I learned in CS and used when I did systems programming (e.g. guard > functions, critical sections, locks, semaphores, etc.).
> Do I need to > look at more enclosing code to see such, are those techniques missing, > are there some newer techniques I do not understand, or something else? I don't know, I will have a look too, though my C[++] is almost as rusty as my Rust :) G
