On Saturday 30 August 2008 22:21:34 Heiko Ei�feldt wrote:
>
> > 1. n <- next step over everything (including grep/map/sort).
> >
> > 2. s <- step into everything (including grep/map/sort).
> >
<snip>
>
> Ok, here is what I did, patch is against Perl 5.10.0.
> Please review, thanks. My simple tests worked so far.
>
From an initial look at it, it looks good to me, (and works nicely ;), too.
Just one thing, you might need to change the regex:
if ( $dbline[$line] =~ m{\bgrep\b}xms
|| $dbline[$line] =~ m{\bmap\b}xms
|| $dbline[$line] =~ m{\bsort\b}xms
) {
to handle join and reverse as well:
if ( $dbline[$line] =~ m{
\b(grep|join|map|reverse|sort)\b
}xms ) {
Maybe try a few single- and multi-line variations and, if it still looks good,
submit a proposed patch to p5p?
--
Richard Foley
Ciao - shorter than aufwiedersehen
http://www.rfi.net/
