#1858: deluge-console: Add command to show and set per-torrent options
---------------------+------------------------------------------------------
Reporter: eirikba | Owner: Cas
Type: patch | Status: assigned
Priority: minor | Milestone: 1.3.x
Component: console | Version: git 1.3-stable
Keywords: |
---------------------+------------------------------------------------------
Comment(by eirikba):
Listing valid options in --help sounds like a good idea.
Displaying torrent names rather than ids, likewise.
Displaying all by default is something that I copied from 'info'.
Requiring being explicit about it is probably better. If we agree that
'*' is a good idea for general use, I can implement that here and SomeOne
can fix the other commands later. (I might make a patch for that
afterwards. Who knows.)
Setting all makes me a bit uneasy, but being explicit and requiring
confirmation would probably be ok. I'll look into it.
I didn't really test many of the options. There's not that many that I
myself generally want to modify. I think I just grabbed the list from
what the implementation of set_torrent_option() seemed to accept. But I
see the list in Torrent.set_options() is different than what I've got.
(e.g. "is_auto_managed" seems to be called "auto_managed" now). I'll
update the list. (Or maybe I pulled the names from the getter rather than
the setter. Hmm, I must remember to double-check that...)
Whether 'manage * --set' is equivalent to 'config -s' I have absolutely no
idea. I would expect 'manage' to set it for all current torrents but not
for any future torrents. While 'config' would set it for all future
torrents, but I don't know if I'd expect it to set it for the current
torrents. But even if it is equivalent, I don't see the harm. I would
think it more harmful if a straightforward, natural command doesn't work
just because you should have used a different command instead.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1858#comment:10>
Deluge <http://deluge-torrent.org/>
Deluge project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/deluge-dev?hl=en.
