[ http://issues.apache.org/jira/browse/DERBY-382?page=comments#action_12314436 ]
Satheesh Bandaram commented on DERBY-382: ----------------------------------------- I am reviewing the Reference Manual and have reviewed first 50 pages. Here are some of the comments I have. I will continue reviewing this book and provide any other comments. Page 13: Change "You are not allowed to create dictionary objects in the SYS schema" to "You are not allowed to create objects in schemas starting with SYS. Page 16: Change "CREATE TABLE statement, and in ORDER BY clauses." to remove "and in ORDER BY clauses". After Tomohito's enhancement, Derby allows this functionality. Page 19: Remove "only if the table is empty or" part in Adding Columns sections. Don't think you can add a NOT NULL constraint even if the table is empty. Page 20: Typo. Bulleting is wrong for "Specify the interval between ..." section. The next two bullets are part of this section, so shouldn't have "." to mark them as different bullets. This might have already been submitted as part of BY DEFAULT identity option. Page 22: Function Element section. Remove the following: [ schema-Name . ] SQL92Identifier Page 26: Procedure Element section. Remove the following: [ schema-Name . ] SQL92Identifier Page 30: I am not sure what this section is doing in the middle of identity section. I think this should be removed or moved to correct place. Note: Specify the schema, table, and column name using the same case as those names are stored in the system tables--that is, all upper case unless you used delimited identifiers when creating those database objects. Page 31: Change "You can create a trigger in any schema except SYS" to "You can create a trigger in any schema except starting with SYS" Page 31: Create trigger section. The Syntax diagram doesn't show NO CASCADE BEFORE triggers. Page 32: Change this paragraph. Derby only has one way to access transition variables or tables. Derby provides you with a number of ways to refer to data that is currently being changed by the database event that caused the trigger to fire. The easiest way to refer to the changed data in the triggered-SQL-statement is use the transition variables or transition tables. TO: Changed data can be referred to in the triggered-SQL-statement using transition variable or transition tables. It may make sense to merge this line with next paragraph. Page 33: Need an example for NO CASCADE BEFORE triggers. Page 33: The order of execution needs to state NO CASCADE BEFORE trigger Page 36: procedure-name in the syntax diagram is not a link to it's definition, like others. Page 37: A statement dependency section needs to be added for DROP SYNONYM Statement dependency system DROP SYNONYM is disallowed if there are any open cursors dependent on the synonym. Page 41: Derby doesn't support NULL as a column level constraint. This section needs to be removed: • NULL The opposite of NOT NULL (not really a constraint), it specifies that the column can hold NULL values. Specifying NULL is the same as saying nothing at all, except when the column is included in a PRIMARY KEY constraint. Page 42: Typo in the section name: Foreign key Cconstraints and DML. Remove the extra C from Cconstraints. Page 43: Remove this line: For backing indexes, you can specify only page size. > Doc Review: Derby Reference Manual > ---------------------------------- > > Key: DERBY-382 > URL: http://issues.apache.org/jira/browse/DERBY-382 > Project: Derby > Type: Improvement > Components: Documentation > Environment: all > Reporter: Jeff Levitt > Priority: Minor > Fix For: 10.1.1.0 > > This issue tracks comments for the Derby Reference Manual. The deadline for > posting comments is Tuesday, June 28, noon Pacific time. > Some guidelines to follow when posting comments to this issue are: > - Try to make clear and concise comments about what you want changed whenever > possible. Provide concrete comments that say "Please change <original> to > <modified>" instead of generic comments like "This section needs to be > rewritten." > - If you're reviewing the HTML Files copy, include the URL for the page in > the review comment. Obtain the URL like this: > * highlight the topic in the left frame > * right click > * choose "Properties" > * copy and paste the address in the pop up box. > - If you're reviewing the PDF copy, in the review comment: > * Include the page number for the PDF, and indicate whether the number is > the PDF sheet number or the printed page number. > * Include the title of the section that the problem occurs in. If it's in > a subsection, try to include the hierarchy of titles. > - Please don't review the HTML Book copy -- it'll be time consuming to match > up that copy with the underlying DITA source. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
