[
https://issues.apache.org/jira/browse/DERBY-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721680#comment-13721680
]
ahsan shamsudeen commented on DERBY-6299:
-----------------------------------------
Hi ,
As I feel, there is no use of creating patches step by step because our later
patches includes all the changes from the initial point. When i look at the
attached DERBY-6299.patch , it includes all the changes from the start. It even
includes changes of previous patches we finished off. So, I feel like same
thing is get repeated in the later created patches. Am I correct ?
Apart from this, As I stated, In my previous comment, the size of the patch to
the whole project is 17.2 Mb. But, 16.7 Mb of is consumed by the fail directory
. This fail directory contains a lot of .dat files and we are not changing any
of these files.Does this fail directory have any impact on the change we do ?
If we create the patch without this directory ,its small(565 KB) and contains
the changes we did.
I have attached the patch which creates a patch to the whole project except the
fail directory. Look at the patch and suggest me any required changes?
Since , I couldn't attach the whole patch of the fail directory, I 'll give you
a sample of a change the fail directory do :
Index: fail/Embedded_40/CallableTest/testgetBytej2/wombat/seg0/c1f1.dat
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: fail/Embedded_40/CallableTest/testgetBytej2/wombat/seg0/c1f1.dat
===================================================================
--- fail/Embedded_40/CallableTest/testgetBytej2/wombat/seg0/c1f1.dat
(revision 0)
+++ fail/Embedded_40/CallableTest/testgetBytej2/wombat/seg0/c1f1.dat
(working copy)
Property changes on:
fail/Embedded_40/CallableTest/testgetBytej2/wombat/seg0/c1f1.dat
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property
Thanks,
Ahsan
> Improve the code coverage of Org.apache.derby.iapi.services.sanity package
> ----------------------------------------------------------------------------
>
> Key: DERBY-6299
> URL: https://issues.apache.org/jira/browse/DERBY-6299
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: ahsan shamsudeen
> Assignee: ahsan shamsudeen
> Priority: Minor
> Attachments: DERBY-6299.patch, DERBY-6299.patch
>
>
> According to the coverage reports, All classes in
> Org.apache.derby.iapi.services.sanity have completely zero coverage.
> So this sub-task is to improve code coverage by doing the following.
>
> 1)Change all the import statements in the code to reference the new location
> of SanityManager and
> AssertFailure
> 2) Delete the wrapper classes
> org.apache.derby.iapi.services.sanity.SanityManager
> org.apache.derby.iapi.services.sanity.AssertFailure
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
