[
https://issues.apache.org/jira/browse/DERBY-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741873#comment-13741873
]
Dag H. Wanvik commented on DERBY-6299:
--------------------------------------
Looks good to me. (BTW, the last part of the patch - for sqlgrammar.sql) didn't
apply cleanly; patch(1) claimed it was malformed, but I was able to apply it
manually.)
Btw, in DataDictionaryImpl I see this test:
if (re instanceof AssertFailure)
which wouldn't have worked before the patch since it tests on the wrapper
class, while
code throwing AssertFailure uses the wrapped class. With the patch this test
would now be correct again.
> Improve the code coverage of Org.apache.derby.iapi.services.sanity package
> ----------------------------------------------------------------------------
>
> Key: DERBY-6299
> URL: https://issues.apache.org/jira/browse/DERBY-6299
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: ahsan shamsudeen
> Assignee: ahsan shamsudeen
> Priority: Minor
> Attachments: bryan.patch, commit.patch, commit.stat,
> DERBY-6299.patch, DERBY-6299.patch, DERBY-6299.patch
>
>
> According to the coverage reports, All classes in
> Org.apache.derby.iapi.services.sanity have completely zero coverage.
> So this sub-task is to improve code coverage by doing the following.
>
> 1)Change all the import statements in the code to reference the new location
> of SanityManager and
> AssertFailure
> 2) Delete the wrapper classes
> org.apache.derby.iapi.services.sanity.SanityManager
> org.apache.derby.iapi.services.sanity.AssertFailure
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
