[
https://issues.apache.org/jira/browse/DERBY-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044533#comment-14044533
]
Dag H. Wanvik commented on DERBY-6638:
--------------------------------------
Hmm.. I think once we have a Javadoc comment it's best it be syntactically
complete. Sometimes filling in
explanatory comments is pretty meaningless (or redundant or not worth it) and I
presume that's why the author didn't do it here, but it does give warnings in
the IDE (and Javadoc if run with the relevant options). As far as the string
concatenation I'm OK with your alternative suggestion although sometimes using
concatenation is briefer (and thus better) in code that isn't performance
critical, in which case one could argue using the @SuppressWarnings is what one
wants. But I'll fix that.
> Remove unnecessary use of reflection in SignatureChecker
> --------------------------------------------------------
>
> Key: DERBY-6638
> URL: https://issues.apache.org/jira/browse/DERBY-6638
> Project: Derby
> Issue Type: Improvement
> Components: Tools
> Reporter: Dag H. Wanvik
> Attachments: derby-6638.diff, derby-6638.status
>
>
> Ca line 377 in SignatureChecker we use reflection to call
> DatabaseMetaData#getFunctionColumns. This is no longer necessary after we
> removed support for JDR 169.
> {color:blue}
> [Update:] There are more occurrences of reflection that can be removed in
> this class.
> {color}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
