[ 
https://issues.apache.org/jira/browse/DERBY-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044581#comment-14044581
 ] 

ASF subversion and git services commented on DERBY-6638:
--------------------------------------------------------

Commit 1605738 from [~dagw] in branch 'code/trunk'
[ https://svn.apache.org/r1605738 ]

DERBY-6638 Remove unnecessary use of reflection in SignatureChecker

Remove the reflection + some missing javadocs and IDE warning fixes.

Removes unused argument from method "checkSignature", and changes all
StringBuilder usage to avoid concatenation.

I tested the tool manually for a simple case, but see DERBY-6639.

> Remove unnecessary use of reflection in SignatureChecker
> --------------------------------------------------------
>
>                 Key: DERBY-6638
>                 URL: https://issues.apache.org/jira/browse/DERBY-6638
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6638-2.diff, derby-6638.diff, derby-6638.status
>
>
> Ca line 377 in SignatureChecker we use reflection to call 
> DatabaseMetaData#getFunctionColumns. This is no longer necessary after we 
> removed support for JDR 169.
> {color:blue}
> [Update:] There are more occurrences of reflection that can be removed in 
> this class.
> {color}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to