"Dyre Tjeldvoll (JIRA)" <[email protected]> writes:
> [ http://issues.apache.org/jira/browse/DERBY-815?page=all ]
>
> Dyre Tjeldvoll updated DERBY-815:
> ---------------------------------
>
> Attachment: derby-815.stat
> derby-815.diff
> derbyall_report.txt
>
> Ran derbyall with the usual failures. I'll let the committers decide
> if it is ok to check in...
Hi Dyre,
Your patch definitely looks like an improvement. A couple of comments
of cosmetic nature, though...
1) The files you have modified use tabs for indentation more or less
consistenly, but you have used spaces. I think it's ok, but it
makes the patch harder to read.
2) CliParam's constructor and getCliParam() could use some line
feeds.
3) In parseSQLDTA_work(), some of the changes are just reformatting,
as far as I can tell:
reader.markCollection();
- codePoint = reader.getCodePoint();
+ int codePoint = reader.getCodePoint();
while (codePoint != -1)
{
- switch (codePoint)
- {
+ switch (codePoint) {
// required
- case CodePoint.FDODSC:
- while (reader.getDdmLength() >
6) //we get parameter info til last 6 byte
+ case CodePoint.FDODSC:
+ while (reader.getDdmLength() > 6) //we get parameter info til
last 6 byte
{
... and later ...
}
ps = cs;
stmt.ps = ps;
- }
+ }
4) You have commented out some code. Couldn't you just delete it?
+ final int numVars = stmt.getNumParams();
//paramDrdaTypes.size();
... and ...
@@ -3917,23 +3932,23 @@
// The first
exception is the most likely suspect
throw se;
}
- rtnParam = true;
+ //rtnParam = true;
}
--
Knut Anders
