[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12434062 ] V.Narayanan commented on DERBY-1547: ------------------------------------
Hi, If you notice the failure pointed out (i.e.) The sed scripts are working fine because the subversion number has been masked as EXPECTED SUBVERSION INFO. This requires a corresponding change in the .out master files so that it would'nt fail on comparison. I however notice that in the .out files the text has been changed to JDBC Driver 'Apache Derby Network Client JDBC Driver', version 10.3 (10.3.0.0 alpha - (1)) instead of JDBC Driver 'Apache Derby Network Client JDBC Driver', version 10.3 (10.3.0.0 alpha-(EXPECTED SUBVERSION INFO)) But the patch I submitted seems to contain the expected changes only (i.e.) -JDBC Driver 'Apache Derby Network Client JDBC Driver', version 10.3 (10.3.0.0 alpha) +JDBC Driver 'Apache Derby Network Client JDBC Driver', version 10.3 (10.3.0.0 alpha-(EXPECTED SUBVERSION INFO)) when I try to apply the patch to a new workspace it works fine for me. I however have not tried applying this patch in a windows environment. Narayanan > Add svn version number to DatabaseMetaData getDatabaseProductVersion and > getDriverVersion() to improve supportability > ----------------------------------------------------------------------------------------------------------------------- > > Key: DERBY-1547 > URL: http://issues.apache.org/jira/browse/DERBY-1547 > Project: Derby > Issue Type: Improvement > Components: JDBC > Affects Versions: 10.1.3.2 > Reporter: Kathey Marsden > Assigned To: V.Narayanan > Priority: Minor > Fix For: 10.2.1.0 > > Attachments: DERBY-1547-sed.diff, DERBY-1547-sed.stat, > DERBY-1547_v1.diff, DERBY-1547_v1.stat, derbyall_fail.txt > > > getDatabaseProductVersion and getDriverVersion() report only the four digit > Derby version number and not the svn build number. It would be useful to > return the full version including the build number as sysinfo does: e.g. > "10.1.2.4 - (392472)", That way it will be clear from application logs that > collect this information exactly what revision level they are running if they > are using rolled up fixes on the maintenance branch between releases. > There may be risk in doing this however if applications are parsing the > version information, but hopefully they will use getDatabaseMajorVersion() , > getDatbaseMinorVersion, getDriverMajorVersion, and getDriverMinorVersion for > such proccessing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
