[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12434419 ] V.Narayanan commented on DERBY-1547: ------------------------------------
Hi, Thank you for taking a look at the patch and taking care to watch the regEx patters also. The brackets are not necessary. I works without them. The regEx was a search for the specific pattern <space><open parenthesis ><digit 1><closed parenthesis><space> (i.e.) the subversion number (1) when you don't do a buildjars. I thought it looked clearer this way. I am not an expert in sed scripts either. Also I agree with the community in that this sed solution is just a filler since this patch has become time critical. If you think a better way is to remove the parenthesis or you think a better regular expression should have been in place pls do guide me so. I will do it promptly. thanx Narayanan > Add svn version number to DatabaseMetaData getDatabaseProductVersion and > getDriverVersion() to improve supportability > ----------------------------------------------------------------------------------------------------------------------- > > Key: DERBY-1547 > URL: http://issues.apache.org/jira/browse/DERBY-1547 > Project: Derby > Issue Type: Improvement > Components: JDBC > Affects Versions: 10.1.3.2 > Reporter: Kathey Marsden > Assigned To: V.Narayanan > Priority: Minor > Fix For: 10.2.1.0 > > Attachments: DERBY-1547-sed-v1.diff, DERBY-1547-sed-v1.stat, > DERBY-1547-sed.diff, DERBY-1547-sed.stat, DERBY-1547_v1.diff, > DERBY-1547_v1.stat, derbyall_fail.txt > > > getDatabaseProductVersion and getDriverVersion() report only the four digit > Derby version number and not the svn build number. It would be useful to > return the full version including the build number as sysinfo does: e.g. > "10.1.2.4 - (392472)", That way it will be clear from application logs that > collect this information exactly what revision level they are running if they > are using rolled up fixes on the maintenance branch between releases. > There may be risk in doing this however if applications are parsing the > version information, but hopefully they will use getDatabaseMajorVersion() , > getDatbaseMinorVersion, getDriverMajorVersion, and getDriverMinorVersion for > such proccessing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
